Products
In-IDE
IDE extension that lets you fix coding issues before they exist!
Discover SonarLint
SaaS
Setup is effortless and analysis is automatic for most languages
Discover SonarCloud
Self-Hosted
Fast, accurate analysis; enterprise scalability
Discover SonarQube

Secrets
ABAP
Ansible
Apex
AzureResourceManager
C
C#
C++
CloudFormation
COBOL
CSS
Dart
Docker
Flex
Go
HTML
Java
JavaScript
JCL
Kotlin
Kubernetes
Objective C
PHP
PL/I
PL/SQL
Python
RPG
Ruby
Scala
Swift
Terraform
Text
TypeScript
T-SQL
VB.NET
VB6
XML

RPG static code analysis

Unique rules to find Bugs, Security Hotspots, and Code Smells in your RPG code

Tags

Impact

Clean code attribute

Subprocedures should not reference global variables
Code Smell
Error handling should be defined in F specs
Code Smell
String literals should not be duplicated
Code Smell
"GOTO" statements should not be used
Code Smell
Variables used in only one subprocedure should not be global
Code Smell
Two branches in a conditional structure should not have exactly the same implementation
Code Smell
Unused subprocedures should be removed
Code Smell
The data area structure for "IN" should be defined in D spec lines.
Code Smell
SQL statements should not join too many tables
Code Smell
The correct "ENDxx" statement should be used
Code Smell
The first parameter of a "CHAIN/READx" statement should be a "KLIST"
Code Smell
The parameters of a "CALL" or "CALLB" statement should be defined as a "PLIST"
Code Smell
"IF" statements should not be conditioned on Indicators
Code Smell
Numeric fields should be defined as odd length packed fields
Code Smell
"E" should be found in F-spec lines
Code Smell
Standard figurative constants *ON, *OFF and *BLANK should be used in place of '1', '0' and ' '
Code Smell
Columns to be read with a "SELECT" statement should be clearly defined
Code Smell
Sections of code should not be commented out
Code Smell
Nested blocks of code should not be left empty
Code Smell
Unused variables should be removed
Code Smell
Indicators should be used on "CHAIN" statements
Code Smell
Unused subroutines should be removed
Code Smell
Subroutine names should comply with a naming convention
Code Smell
Track lack of copyright and license headers
Code Smell
Subprocedures should be used instead of subroutines
Code Smell
Subroutines should not be too complex
Code Smell
Control flow statements "IF", "FOR", "DO", ... should not be nested too deeply
Code Smell
"IF ... ELSEIF" constructs should end with "ELSE" clauses
Code Smell
Expressions should not be too complex
Code Smell
Multiple occurrence data structures should not be used
Code Smell
Compile-time arrays should not be used
Code Smell
"QUALIFIED" data structures should be used
Code Smell
Prototypes should be used
Code Smell
The "*srcstmt" header option should be used
Code Smell
"IF" blocks should not have too many lines of code
Code Smell
"DO" blocks should not have too many lines of code
Code Smell
"/COPY" should be avoided
Code Smell
Track uses of disallowed operation codes
Code Smell
LIKE keyword should be used to define work fields
Code Smell
Subroutines should be documented
Code Smell
Subroutines should not have too many lines of code
Code Smell
"SELECT WHEN" clauses should not have too many lines of code
Code Smell
Files should not have too many lines of code
Code Smell
Optional operation codes should be omitted
Code Smell
Comment lines should not be too long
Code Smell
"/COPY" statements should include specification letters
Code Smell
Standard language features should be in upper case
Code Smell
"/EJECT" should be used after "F", "D" and "C" specification sections
Code Smell
"CONST" should be used for parameters that are not modified
Code Smell

Numeric fields should be defined as odd length packed fields

intentionality - efficient

maintainability

Code Smell

MajorSonarSource default severity
click to learn more

Why is this an issue?

When storing numeric fields, using an odd number of digits allows the sign to be included in the storage area without wasting any space.

For example the number -1234567, when packed as 7 digits is stored as follows.

1357
246-

thus taking up only 4 data slots. but when packed as 8 characters it uses 5 data slots

02467
0135-

or when 7 digits, non-packed, it will be stored as 8 data slots, including the sign.

FFFFFFF6
12345670

Noncompliant code example

     D NUMFLD          S              8P 0
     D NUMFLD          S              7S 0

Compliant solution

     D NUMFLD          S              7P 0

Available In:

Catch issues on the fly,
in your IDE

Enterprise
Edition

© 2008-2024 SonarSource SA. All rights reserved. SONAR, SONARSOURCE, SONARQUBE, and CLEAN AS YOU CODE are trademarks of SonarSource SA.

Sonar helps developers write Clean Code.
Privacy Policy | Cookie Policy

In-IDE

SaaS

Self-Hosted